Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using importlib_metadata for entry points instead of pkg_resources #1973

Closed

Conversation

jeremydvoss
Copy link
Contributor

Description

pkg_resources is deprecated. Following example of https://github.com/open-telemetry/opentelemetry-python/pull/3217/files

Helps to fix #1970

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@pcorpet
Copy link

pcorpet commented Nov 1, 2023

Any chance to see this PR moving forward please? Can I help in some ways?

@pcorpet
Copy link

pcorpet commented Jan 21, 2024

@jeremydvoss can I help you finalize this PR?

@multani
Copy link

multani commented Mar 6, 2024

@jeremydvoss Do you have any plan with this change? It would be great if these warnings get fixed! 🙇

@Olegt0rr
Copy link
Contributor

@jeremydvoss, do need any help with this PR?
Please, don't abandon it :(

@multani
Copy link

multani commented Jul 16, 2024

It has been several months already without any updates or comments. I will try to propose a new change on top of this one in the coming days, with updated code to fix all the warnings.

@multani
Copy link

multani commented Jul 16, 2024

Actually, it's already picked up in #2181

@xrmx xrmx mentioned this pull request Oct 17, 2024
11 tasks
@lzchen lzchen closed this in #2871 Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opentelemetry instrumentation uses deprecated pkg_resources.
4 participants