Azure Monitor opentelemetry exporter uses deprecated locale.getdefaultlocale

[jenshnielsen]

• Package Name: azure-monitor-opentelemetry-exporter
• Package Version: 1.0.0.b17
• Operating System: windows 11
• Python Version: python 3.11

Describe the bug
Using Azure Monitor Opentelemetry exporter triggers a deprecation warning

C:\Users\jenielse\Miniconda3\envs\myenv\Lib\site-packages\azure\monitor\opentelemetry\exporter_utils.py:57: DeprecationWarning: Use setlocale(), getencoding() and getlocale() instead
"ai.device.locale": locale.getdefaultlocale()[0],

To Reproduce
Steps to reproduce the behavior:

1. Configure export with azure monitor opentelemetry exporter.

Or any other opteration that triggers an import of _utils.py from the package

Expected behavior

No deprecation warning.

Additional context

Afaik this only became deprecated in python 3.11

Note however that on windows the replacement has some issues python/cpython#82986

[xiangyan99]

Thanks for the feedback, we’ll investigate asap.

[pamelafox]

There's also another deprecation warning in similar code (opentelemetry):

../../home/vscode/.local/lib/python3.11/site-packages/azure/monitor/opentelemetry/_vendor/v0_39b0/opentelemetry/instrumentation/dependencies.py:4
  /home/vscode/.local/lib/python3.11/site-packages/azure/monitor/opentelemetry/_vendor/v0_39b0/opentelemetry/instrumentation/dependencies.py:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import (

[jenshnielsen]

@pamelafox Yes I actually reported that one over here open-telemetry/opentelemetry-python-contrib#1970 (this issue was fixed in opentelemetry sdk/api a few months ago but not in contrib/instrumentation yet

[lzchen]

@jenshnielsen

Interesting that you are seeing the warning messages. DeprecationWarnings should be ignored for code that is not directly executed from main but this might come up possibly in CI runs.

Regardless, it seems that getdefaultlocale() will be removed in py3.13 so we might want to switch over before that happens to avoid breaking code. The windows issue with getlocale() is a bit concerning so we might be better off simply just to ignore deprecation warnings before py3.13 comes out, similar to here. Thoughts?

[pamelafox]

I don't know about @jenshnielsen but I use pytest to test our app code, and pytest defaults to showing warnings like the deprecation warnings, so they add a lot of noise to pytest output. We can filter them out but it's always nicer when code is upgraded, where it makes sense.

[jenshnielsen]

I indeed noticed it via our test suite and pytest too.

[lzchen]

@pamelafox

There's a pr in upstream opentelemetry that will fix this issue