Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an option to configure disable_aws_context_propagation by environment variable #1507

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Dec 19, 2022

Description

The variable OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION can be used to disable aws context propagation. This is similar to the proposed changes in the JS implementation: open-telemetry/opentelemetry-js-contrib#1227

Signed-off-by: Alex Boten aboten@lightstep.com

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

…ronment variable

The variable `OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION` can be used to disable aws context propagation. This is similar to the proposed changes in the JS implementation: open-telemetry/opentelemetry-js-contrib#1227

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from a team December 19, 2022 19:41
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some questions regarding testing

srikanthccv and others added 2 commits December 20, 2022 03:27
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
@ocelotl ocelotl merged commit 7f8fe69 into open-telemetry:main Dec 19, 2022
@codeboten codeboten deleted the codeboten/envvar-disable-ctx-prop branch January 3, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants