-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature matrix #430
add feature matrix #430
Conversation
Adding the initial feature matrix with some descriptions of the features captured in the matrix. Signed-off-by: Alex Boten <aboten@lightstep.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this matrix also include a section about auto-instrumentation?
use runtime as header, break up semantic conventions into sections and add auto-instrumentation section Signed-off-by: Alex Boten <aboten@lightstep.com>
@tsloughter @avzis updated the matrix based on your feedback, please take a look |
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one more comment but its not blocking.
|
||
| Feature | Node | Python | Java | .NET | Go | Ruby | | ||
| -------------------------- | :--: | :----: | :--: | :--: | :--: | :--: | | ||
| OpenTelemetry collector | + | + | + | + | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| OpenTelemetry collector | + | + | + | + | | | | |
| Layer | | | | | | | | |
| - OpenTelemetry collector | + | + | + | + | | | | |
| - Auto-instrumentation | | | | | | | |
This is what I was suggesting to convey that there will still be layers for languages like Go but they only have the collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right I guess in my mind everything on this list pertains to the layer :) happy to talk about this in a follow up pr 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was on the wrong account in my first approval :)
Adding the initial feature matrix with some descriptions of the features captured in the matrix.
Signed-off-by: Alex Boten aboten@lightstep.com