Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature matrix #430

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Conversation

codeboten
Copy link
Contributor

Adding the initial feature matrix with some descriptions of the features captured in the matrix.

Signed-off-by: Alex Boten aboten@lightstep.com

Adding the initial feature matrix with some descriptions of the features captured in the matrix.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from Aneurysm9 as a code owner January 17, 2023 22:19
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@avzis avzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this matrix also include a section about auto-instrumentation?

use runtime as header, break up semantic conventions into sections and add auto-instrumentation section

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten
Copy link
Contributor Author

@tsloughter @avzis updated the matrix based on your feedback, please take a look

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
codeboten and others added 3 commits January 24, 2023 10:06
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link

@tsloughter-splunk tsloughter-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one more comment but its not blocking.


| Feature | Node | Python | Java | .NET | Go | Ruby |
| -------------------------- | :--: | :----: | :--: | :--: | :--: | :--: |
| OpenTelemetry collector | + | + | + | + | | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| OpenTelemetry collector | + | + | + | + | | |
| Layer | | | | | | |
| - OpenTelemetry collector | + | + | + | + | | |
| - Auto-instrumentation | | | | | | |

This is what I was suggesting to convey that there will still be layers for languages like Go but they only have the collector.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right I guess in my mind everything on this list pertains to the layer :) happy to talk about this in a follow up pr 👍🏻

Copy link
Member

@tsloughter tsloughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was on the wrong account in my first approval :)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@codeboten codeboten merged commit dc7baa0 into open-telemetry:main Jan 25, 2023
@codeboten codeboten deleted the codeboten/matrix branch January 25, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants