-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP JSON payload examples #463
Add OTLP JSON payload examples #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I know that we will do manual work here withe these examples. should we have at least a check that they are valid JSONs?
Yes more checks would be useful. Related: we have a PR coming that adds link checking: #459 |
I was also thinking if we shouldn't publish a json schema for OTLP. That way the guess work of writing OTLP JSON is removed and we could also check it against the schema in a gh action. I saw some tool to generate JSON schema from proto files but didn't have time to check. If you think it's valid, I can create issues and maybe work on it. |
I would not want to maintain another schema definition. The Protobuf definitions are the source of truth. If we could generate JSON schema from Protobufs that would be great. |
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Merging. @joaopgrassi it would be great if you could follow up with a PR to add JSON checks. |
Will do! |
Hi all, I've posted a suggestion to: Comments are welcome. |
Fixes #462
I was not sure where to add the files, so I just went with some initial idea. I'm open to suggestions on where to put them/refer to them.
I tested it with a local collector and all works.
cc @tigrannajaryan