-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link checking #459
Merged
tigrannajaryan
merged 3 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/linkcheck
May 10, 2023
Merged
Add link checking #459
tigrannajaryan
merged 3 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/linkcheck
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdown-link-check is expected to fail since we have some broken links. |
Can you fix the dead link? |
jack-berg
reviewed
Apr 27, 2023
Yes, will be fixed by this: #458 |
Kielek
reviewed
Apr 28, 2023
Links are now fixed and the check is passing. |
@open-telemetry/specs-approvers please review. |
@open-telemetry/specs-approvers please review. |
@open-telemetry/specs-approvers please review. |
jack-berg
approved these changes
May 9, 2023
jsuereth
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed from https://github.com/open-telemetry/opentelemetry-specification