Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min/max fields to HistogramDataPoint #279

Merged
merged 14 commits into from
Apr 1, 2022
Merged

Add min/max fields to HistogramDataPoint #279

Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3a83954
Add min/max fields to HistogramDataPoint
jmacd Mar 15, 2021
0a6b972
Typos
jmacd Mar 15, 2021
9fc3215
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jmacd Sep 16, 2021
af32e8b
10 minutes
jmacd Sep 16, 2021
4d839aa
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jmacd Oct 5, 2021
9a3f857
make min/max optional but strictly refer to (start_time, end_time]
jmacd Oct 5, 2021
29639a5
Merge branch 'main' of github.com:open-telemetry/opentelemetry-proto …
jmacd Feb 2, 2022
3149875
--experimental_allow_proto3_optional
jmacd Feb 2, 2022
6f6a18c
remove gogo
jmacd Feb 2, 2022
656c1d9
Merge branch 'main' of github.com:open-telemetry/opentelemetry-proto …
jmacd Mar 2, 2022
21792bb
Changelog
jmacd Mar 2, 2022
de93740
Merge branch 'main' of github.com:open-telemetry/opentelemetry-proto …
jmacd Apr 1, 2022
39a83fa
revert accidental makefile
jmacd Apr 1, 2022
2f9dad4
Merge branch 'main' into jmacd/minmax
jmacd Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,12 @@ message HistogramDataPoint {
// Flags that apply to this specific data point. See DataPointFlags
// for the available flags and their meaning.
uint32 flags = 10;

// min is the minimum value over (start_time, end_time].
optional double min = 11;
jmacd marked this conversation as resolved.
Show resolved Hide resolved

// max is the maximum value over (start_time, end_time].
optional double max = 12;
}

// ExponentialHistogramDataPoint is a single data point in a timeseries that describes the
Expand Down Expand Up @@ -575,6 +581,12 @@ message ExponentialHistogramDataPoint {
// (Optional) List of exemplars collected from
// measurements that were used to form the data point
repeated Exemplar exemplars = 11;

// min is the minimum value over (start_time, end_time].
optional double min = 12;

// max is the maximum value over (start_time, end_time].
optional double max = 13;
}

// SummaryDataPoint is a single data point in a timeseries that describes the
Expand Down