Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max fields to HistogramDataPoint #279

Merged
merged 14 commits into from
Apr 1, 2022
Merged
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ Full list of differences found in [this compare](https://github.com/open-telemet

### Changed

* Remove if no changes for this section before release.
* Introduce optional `min` and `max` fields to the Histogram and ExponentialHistogram data points.
[(#279)](https://github.com/open-telemetry/opentelemetry-proto/pull/279)

### Added

Expand Down
12 changes: 12 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,12 @@ message HistogramDataPoint {
// Flags that apply to this specific data point. See DataPointFlags
// for the available flags and their meaning.
uint32 flags = 10;

// min is the minimum value over (start_time, end_time].
optional double min = 11;
jmacd marked this conversation as resolved.
Show resolved Hide resolved

// max is the maximum value over (start_time, end_time].
optional double max = 12;
}

// ExponentialHistogramDataPoint is a single data point in a timeseries that describes the
Expand Down Expand Up @@ -594,6 +600,12 @@ message ExponentialHistogramDataPoint {
// (Optional) List of exemplars collected from
// measurements that were used to form the data point
repeated Exemplar exemplars = 11;

// min is the minimum value over (start_time, end_time].
optional double min = 12;

// max is the maximum value over (start_time, end_time].
optional double max = 13;
}

// SummaryDataPoint is a single data point in a timeseries that describes the
Expand Down