Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max fields to HistogramDataPoint #279

Merged
merged 14 commits into from
Apr 1, 2022
Merged
22 changes: 22 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,28 @@ message DoubleHistogramDataPoint {
// (Optional) List of exemplars collected from
// measurements that were used to form the data point
repeated DoubleExemplar exemplars = 8;

// Note: the definition used to for min and max fields below is
// based on temporality in a way meant to match the Prometheus
// Summary data type used with quantiles 0 and 1, respectively, when
// paired with cumulative temporality. This uses a fixed width that
// SHOULD be up to 5-10 minutes or for as long as data is available.
// https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#summary
jmacd marked this conversation as resolved.
Show resolved Hide resolved

// min is the minimum value over a recent window of time.
jmacd marked this conversation as resolved.
Show resolved Hide resolved
//
// The interpretation is based on Metric's temporality.
// - delta temporality: the min value MUST be computed over over [start_time, end_time]
// - cumulative temporality: the min value SHOULD be computed over [now - WIDTH, end_time]
// for WIDTH in the 5-10 minute range.
double min = 13;
jmacd marked this conversation as resolved.
Show resolved Hide resolved

// max is the maximum value over a recent window of time.
//
// The interpretation is based on Metric's temporality.
// - delta temporality: the max value MUST be computed over over [start_time, end_time]
jmacd marked this conversation as resolved.
Show resolved Hide resolved
// - cumulative temporality: the max value SHOULD be computed over [now - WIDTH, end_time]
double max = 14;
}

// SummaryDataPoint is a single data point in a timeseries that describes the
Expand Down