Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional traceresponse propagation to Symfony auto-instrumentation #146

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

cedricziel
Copy link
Contributor

Depends on #143

…tion

Add composer suggest

dont mention x-ray

CS Fix: Fix import order
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #146 (980d6bb) into main (ba372ed) will increase coverage by 20.32%.
The diff coverage is n/a.

❗ Current head 980d6bb differs from pull request most recent head 8d18529. Consider uploading reports for the commit 8d18529 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #146       +/-   ##
=============================================
+ Coverage     25.88%   46.21%   +20.32%     
+ Complexity      319      181      -138     
=============================================
  Files            33       18       -15     
  Lines          1321      647      -674     
=============================================
- Hits            342      299       -43     
+ Misses          979      348      -631     
Flag Coverage Δ
7.4 85.42% <ø> (+12.40%) ⬆️
8.0 0.00% <ø> (-30.29%) ⬇️
8.1 46.21% <ø> (+15.84%) ⬆️
8.2 70.85% <ø> (+44.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba372ed...8d18529. Read the comment docs.

@cedricziel cedricziel marked this pull request as ready for review April 11, 2023 08:26
@cedricziel cedricziel requested a review from a team April 11, 2023 08:26
@cedricziel
Copy link
Contributor Author

Needs to be run after open-telemetry/opentelemetry-propagation-traceresponse was created in packagist.

@bobstrecansky
Copy link
Collaborator

@cedricziel - are you ready for this to be merged?

@cedricziel cedricziel closed this Apr 12, 2023
@cedricziel cedricziel reopened this Apr 12, 2023
@cedricziel
Copy link
Contributor Author

Yep, let's go @bobstrecansky

@bobstrecansky bobstrecansky merged commit 86f053c into open-telemetry:main Apr 12, 2023
@cedricziel cedricziel deleted the traceresponse-auto branch April 12, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants