-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceResponse propagator #143
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
============================================
+ Coverage 25.03% 25.88% +0.85%
- Complexity 315 319 +4
============================================
Files 32 33 +1
Lines 1306 1321 +15
============================================
+ Hits 327 342 +15
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
A couple of small things from me, but this looks good. We might need to think about how this propagator interacts with the tracecontext one; for example we current can globally configure a propagator which is then accessible from |
True - the reason i didnt opt for this, is that traceresponse is strictly limited to responses and without a specific setter implementation, the propagator wont know. My first approach was to explore in core to have |
Cleanup dependencies Add PHPStan config and clean code Allow PHP 7 compatible symfony/http-client Add TraceResponse to .gitsplit Fix test method casing
81b85bb
to
5ef730f
Compare
5ef730f
to
24632e7
Compare
Note: This introduces a new experimental package as
traceresponse
is currently a w3c editors' draft.This package provides a Trace Context HTTP Response Headers Format
propagator to inject the current span context into Response datastructures.
The main goal is to allow client-side technology (Real User Monitoring, HTTP Clients) to record
the server side context in order to allow referencing or assuming it.