Add aws xray receiver #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct, but if the default port is on UDP, then we might want to handle that as well. Otherwise, we'll open a default port for TCP when it should be UDP. |
|
In AWS xray receiver the port for both UDP and TCP are the same, they differentiate this with another field called transport user should configure it as either Aws xray udp endpoint |
|
@jpkrohling once #422 gets merged I will rebase this PR to resolve the conflicts. |
jpkrohling
reviewed
Sep 13, 2021
| const parserNameAWSXRAY = "__awsxray" | ||
|
|
||
| // NewAwsXrayReceiverParser builds a new parser for AWS xray receivers, from the contrib repository. | ||
| func NewAwsXrayReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) ReceiverParser { |
There was a problem hiding this comment.
Suggested change
| func NewAwsXrayReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) ReceiverParser { | |
| func NewAWSXrayReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) ReceiverParser { |
jpkrohling
approved these changes
Sep 13, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing AWS XRAY receiver from collector-contrib. Added the default port as
2000as mentioned inREADME.md.Just to be clear I am not adding any other default config parameters such as
transportasudpand other fields as we expect this to be taken care by users right?. We are only concerned with default port that needs to be exposed for this particular receiver.WDYT @jpkrohling ?
Part of #128