Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync list of receivers #128

Closed
14 tasks
jpkrohling opened this issue Nov 24, 2020 · 17 comments
Closed
14 tasks

Sync list of receivers #128

jpkrohling opened this issue Nov 24, 2020 · 17 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Nov 24, 2020

The operator knows about a few receivers, but I'm not sure this list is up to date:
https://github.com/open-telemetry/opentelemetry-operator/tree/master/pkg/collector/parser

This ticket is to sync this list.

Current delta:

  • awscontainermetrics
  • awsxray
  • dockerstats
  • jmx
  • k8scluster
  • kubeletstats
  • memcached
  • nginx
  • prometheusexec
  • recever
  • redis
  • simpleprometheus
  • splunk
  • stanza
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers labels Nov 24, 2020
@gramidt
Copy link
Member

gramidt commented Jan 23, 2021

I'll take this @jpkrohling

@gramidt
Copy link
Member

gramidt commented Jan 23, 2021

The current deltas:

collector

Currently update to date. May need to compare settings to make sure everything is still following convention.

collector-contrib

  • awscontainermetrics
  • awsxray
  • dockerstats
  • jmx
  • k8scluster
  • kubeletstats
  • memcached
  • nginx
  • prometheusexec
  • recever
  • redis
  • simpleprometheus
  • splunk
  • stanza

@gramidt
Copy link
Member

gramidt commented Jan 23, 2021

@jpkrohling - What are your thoughts about the "collector-contrib" receivers? Was your plan to rely on receiver_generic.go for deltas?

@jpkrohling
Copy link
Member Author

No, the generic is just an implementation detail, as most receivers can be managed in the same way. Basically, if the receiver has an endpoint property that accepts a host:port value, it can make use of the generic adapter.

@jpkrohling
Copy link
Member Author

Perhaps it was implicit in the comment above, but for now, all we care about is the endpoint property for the receiver, as we'll use this to automatically add the needed ports to the Service. So, there's no need to sync the other properties in each receiver.

@gramidt
Copy link
Member

gramidt commented Jan 25, 2021

Perfect! That's exactly what I was thinking. I'll start tackling the deltas 1-by-1 with individual PRs for each. Should we also split this into multiple issues, @jpkrohling?

@jpkrohling
Copy link
Member Author

This issue here has the list of receivers already, if we reference this issue in all individual PRs, it should be fine.

@gramidt
Copy link
Member

gramidt commented Jan 26, 2021

@jpkrohling - Could you add me as an assignee, so I can more easily track this work?

@jpkrohling
Copy link
Member Author

Done

@gramidt
Copy link
Member

gramidt commented Jan 26, 2021

Thank you!

@gramidt
Copy link
Member

gramidt commented Feb 3, 2021

@jpkrohling and community - Quick update: I'm planning to start this work either later this week or early next week. My current OSS backlog includes finishing the Loki exporter ( open-telemetry/opentelemetry-collector-contrib#1894 ), adding a small feature to the F5 Cloud exporter, then circling back to this.

@VineethReddy02
Copy link
Contributor

I can take this up! :)

@jpkrohling
Copy link
Member Author

It's yours, @VineethReddy02!

@VineethReddy02
Copy link
Contributor

VineethReddy02 commented Jul 29, 2021

This is the list of receivers from contrib repo

Below receivers already exist in the operator

carbon
collectd
sapm
signalfx
wavefront
zipkin

Delta receivers that aren't scrapers

awsxray
fluentforward
influxdb
kafka
receivercreator
splunkhec
statsd
syslog
tcplog
udplog

Scrapers (which should be ignored as we do not expose any ports for scrapers)

awscontainerinsight
awsecscontainermetrics
dockerstats
dotnetdiagnostics
filelog
jmx
googlecloudpubsub
hostmetrics
k8scluster
kafkametrics
kubeletstats
memcached
nginx
podman
prometheusexec
prometheus
redis
simpleprometheus
zookeeper
windowsperfcounters

@yuriolisa
Copy link
Contributor

@jpkrohling, is that issue done, or should we implement the following receivers?

kafka
receivercreator
syslog

@yuriolisa
Copy link
Contributor

@pavolloffay, how should we proceed with that issue?

@pavolloffay
Copy link
Member

I would propose to close this and add components per request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants