Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add datadog parser #1496

Closed

Conversation

yuriolisa
Copy link
Contributor

Part of #128.

Parser to Datadog receiver.

@yuriolisa yuriolisa requested a review from a team February 22, 2023 09:35
@yuriolisa yuriolisa added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 22, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
@yuriolisa yuriolisa removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 27, 2023
@yuriolisa
Copy link
Contributor Author

@pavolloffay, @frzifus , could you please take a look?

@yuriolisa
Copy link
Contributor Author

@pavolloffay, @frzifus, could you please take a look?


package parser

// all tests for the Statsd parser are currently part of the test TestDownstreamParsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment is wrong.

I don't understand why this file is even here. Also, new parsers needs to be added to the generic test suite.

@yuriolisa yuriolisa closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants