Added PodMonitor when using sidecar mode #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
swiatekm
reviewed
Nov 30, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
swiatekm
reviewed
Nov 30, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
pavolloffay
reviewed
Dec 4, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
swiatekm
reviewed
Dec 5, 2023
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
jaronoff97
approved these changes
Dec 5, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added PodMonitor when using sidecar mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> --------- Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding PodMonitor when using a combination of sidecar mode and Prometheus exporters.
Link to tracking Issue:
Resolves #2306
Testing:
Created e2e test which will deploy a collector using sidecar mode and tested if we get the expected PodMonitor created.
Documentation: