Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitors for Prometheus exporter in sidecar mode #2306

Closed
lwj opened this issue Nov 2, 2023 · 4 comments · Fixed by #2404
Closed

Monitors for Prometheus exporter in sidecar mode #2306

lwj opened this issue Nov 2, 2023 · 4 comments · Fixed by #2404
Assignees
@yuriolisa
Labels
area:collector Issues for deploying collector enhancement New feature or request good first issue Good for newcomers

Comments

@lwj
Copy link

lwj commented Nov 2, 2023

Component(s)

operator

Is your feature request related to a problem? Please describe.

Relates to #1983

Generating a ServiceMonitor for a collector using observability.metrics.enableMetrics: true works fine using the deployment mode, but when generating for the sidecar mode, the ServiceMonitor will not scrape metrics from the sidecar.

Describe the solution you'd like

I don't believe this can be solved using the current implementation with ServiceMonitors, as the operator won't have visibility of the services generated for the injected applications.

Could we use a PodMonitor instead in the sidecar case? Perhaps matching on the sidecar.opentelemetry.io/injected label. Also won't want to restrict to the namespace the collector is defined in, as it could feasibly be used from any.

Describe alternatives you've considered

No response

Additional context

No response
@lwj lwj added enhancement New feature or request needs triage labels Nov 2, 2023
@jaronoff97
Copy link
Contributor

I think using a podmonitor is a great idea! That should work, and i don't think it's objectionable. Interested in other opinions.

@jaronoff97 jaronoff97 added good first issue Good for newcomers area:collector Issues for deploying collector area:controller and removed needs triage labels Nov 3, 2023
@yuriolisa
Copy link
Contributor

Agree with the idea. @jaronoff97 or @lwj are you willing to send a contribution or can I take this one?

@jaronoff97
Copy link
Contributor

I don't have the capacity right now, but happy to assign someone interested!

@yuriolisa
Copy link
Contributor

Let me take this one.

@yuriolisa yuriolisa mentioned this issue Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriolisa yuriolisa

Labels
area:collector Issues for deploying collector enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added PodMonitor when using sidecar mode yuriolisa/opentelemetry-operator
3 participants
@jaronoff97 @lwj @yuriolisa