Added updateStrategy to DaemonSet mode #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
|
@frzifus, WDYT to include |
Signed-off-by: Yuri Sa <yurimsa@gmail.com> Added updateStrategy to DaemonSet mode Signed-off-by: Yuri Sa <yurimsa@gmail.com>
yuriolisa
force-pushed
the
add-updatestrategy
branch
from
8d1165b to
6ff4cd2
Compare
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
jaronoff97
approved these changes
Nov 14, 2023
frzifus
reviewed
Nov 16, 2023
| @@ -275,6 +276,11 @@ type OpenTelemetryCollectorSpec struct { | |||
| // object, which shall be mounted into the Collector Pods. | |||
| // Each ConfigMap will be added to the Collector's Deployments as a volume named `configmap-<configmap-name>`. | |||
| ConfigMaps []ConfigMapsSpec `json:"configmaps,omitempty"` | |||
| // UpdateStrategy represents the strategy the operator will take replacing existing DaemonSet pods with new pods | |||
| // https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec | |||
| // This is only applicable to Daemonset mode. | |||
There was a problem hiding this comment.
Does it make sense to validate this in the validation webhook?
There was a problem hiding this comment.
Good point! I'll add a validation to enable this field only for DaemonSet mode.
There was a problem hiding this comment.
Just added the validation you mentioned. Could you please have a look?
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
frzifus
approved these changes
Nov 16, 2023
jaronoff97
approved these changes
Nov 16, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Added updateStrategy to DaemonSet mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added updateStrategy to DaemonSet mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added updateStrategy to DaemonSet mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> Added updateStrategy to DaemonSet mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added webhooks test for DaemonSet Mode Signed-off-by: Yuri Sa <yurimsa@gmail.com> --------- Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added updateStrategy field regarding the way existing DaemonSet pods will be replaced to new pods.
Link to tracking Issue:
Resolves: #2107
Testing:
Created unit tests and e2e tests to check if these fields have been properly populated.
Documentation:
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec