Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring updateStrategy in collector workloads #2107

Closed
sfc-gh-rscott opened this issue Sep 12, 2023 · 2 comments · Fixed by #2305
Closed

Support configuring updateStrategy in collector workloads #2107

sfc-gh-rscott opened this issue Sep 12, 2023 · 2 comments · Fixed by #2305
Assignees
@yuriolisa
Labels
area:collector Issues for deploying collector enhancement New feature or request

Comments

@sfc-gh-rscott
Copy link

Currently it's not possible to configure the updateStrategy for collector workloads. This has the effect of setting maxUnavailable to 1 for DaemonSet workloads, which causes rollouts to take a long time in clusters with many nodes. It would be great to be able to set .spec.updateStrategy.rollingUpdate.maxUnavailable to something other than 1.
@frzifus frzifus added enhancement New feature or request area:collector Issues for deploying collector labels Sep 12, 2023
@yuriolisa
Copy link
Contributor

@frzifus, are you working on it or can I take this one?

@frzifus
Copy link
Member

frzifus commented Oct 18, 2023

Nope, please go ahead 😄

@yuriolisa yuriolisa self-assigned this Oct 19, 2023
@yuriolisa yuriolisa mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriolisa yuriolisa

Labels
area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added updateStrategy to DaemonSet mode yuriolisa/opentelemetry-operator
3 participants
@frzifus @yuriolisa @sfc-gh-rscott