Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put reconciliation errors in CRD events #1972

Closed
jaronoff97 opened this issue Jul 28, 2023 · 3 comments · Fixed by #2193
Closed

Put reconciliation errors in CRD events #1972

jaronoff97 opened this issue Jul 28, 2023 · 3 comments · Fixed by #2193
Labels
help wanted Extra attention is needed
Milestone
Collector v1beta1...

Comments

@jaronoff97
Copy link
Contributor

A user shouldn't need to look at operator logs for CRD reconciliation problems. We should add them proactively on the CRD's events to make clear why something couldn't be reconciled. This will be easier with the completion of #1876
@pavolloffay
Copy link
Member

+1

@pavolloffay pavolloffay added the help wanted Extra attention is needed label Jul 31, 2023
@iblancasa
Copy link
Contributor

I would like to work on this. Could you assign this task to me? Thanks!

@jaronoff97
Copy link
Contributor Author

@iblancasa i want to complete #1876 first which will make setting status much easier hopefully... but happy to assign you!

@jaronoff97 jaronoff97 mentioned this issue Aug 7, 2023
Merged
@taniyourstruly taniyourstruly mentioned this issue Oct 11, 2023
Merged
@jaronoff97 jaronoff97 mentioned this issue Nov 28, 2023
Closed
@jaronoff97 jaronoff97 added this to the v1alpha2 CRD release milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
Collector v1beta1 CRD release
Development

Successfully merging a pull request may close this issue.

Enhanced Reconciliation Errors taniyourstruly/opentelemetry-operator
3 participants
@iblancasa @pavolloffay @jaronoff97