Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate basic reconcile functionality into a reusable package #1876

Closed
avadhut123pisal opened this issue Jun 28, 2023 · 1 comment · Fixed by #1995
Closed

Isolate basic reconcile functionality into a reusable package #1876

avadhut123pisal opened this issue Jun 28, 2023 · 1 comment · Fixed by #1995
Assignees
@jaronoff97
Labels
area:opamp Issues for the opamp resource

Comments

@avadhut123pisal
Copy link
Contributor

I would propose to open a separate PR to isolate basic reconcile functionality e.g. methods like expected.../delete... into a reusable package. Or even better refactor the code and use mutate func for all object types e.g. https://github.com/grafana/tempo-operator/blob/main/internal/manifests/mutate.go#L27 with https://github.com/grafana/tempo-operator/blob/1a49fbb282ff1596fd874887341b80192eecffc1/controllers/tempo/tempostack_controller.go#L250

Originally posted by @pavolloffay in #1559 (comment)
@jaronoff97
Copy link
Contributor

I can take this on :)

@jaronoff97 jaronoff97 self-assigned this Jun 28, 2023
@jaronoff97 jaronoff97 added the area:opamp Issues for the opamp resource label Jul 17, 2023
This was referenced Jul 24, 2023
Closed
Merged
Closed
@jaronoff97 jaronoff97 mentioned this issue Aug 16, 2023
Open
@jaronoff97 jaronoff97 mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaronoff97 jaronoff97

Labels
area:opamp Issues for the opamp resource
Projects
None yet
Milestone
No milestone
2 participants
@jaronoff97 @avadhut123pisal