Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block bad resources from reconciliation #2399

Closed
jaronoff97 opened this issue Nov 28, 2023 · 1 comment · Fixed by #3180
Closed

Block bad resources from reconciliation #2399

jaronoff97 opened this issue Nov 28, 2023 · 1 comment · Fixed by #3180
Labels
area:collector Issues for deploying collector enhancement New feature or request

Comments

@jaronoff97
Copy link
Contributor

Component(s)

collector

Is your feature request related to a problem? Please describe.

Following up from #1972 , we should check for manifest errors in the webhook(s) and prevent objects from being created when we know they will not work.

Describe the solution you'd like

Modify the existing validating webhooks to run the manifest generators checking for any errors that may exist.

Describe alternatives you've considered

No response

Additional context

No response
@jaronoff97 jaronoff97 added enhancement New feature or request area:collector Issues for deploying collector labels Nov 28, 2023
@jaronoff97 jaronoff97 added this to the v1alpha2 CRD release milestone Nov 28, 2023
@jaronoff97
Copy link
Contributor Author

@taniyourstruly is going to take this one on after her great work on #1972

@jaronoff97 jaronoff97 mentioned this issue Nov 28, 2023
Closed
@jaronoff97 jaronoff97 mentioned this issue Jan 30, 2024
Closed
@pavolloffay pavolloffay removed this from the Collector v1beta1 CRD release milestone Apr 5, 2024
@jaronoff97 jaronoff97 mentioned this issue Apr 16, 2024
Merged
@taniyourstruly taniyourstruly mentioned this issue Jul 29, 2024
Merged
@taniyourstruly taniyourstruly mentioned this issue Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhanced Webhook Reconciliation Errors taniyourstruly/opentelemetry-operator
2 participants
@pavolloffay @jaronoff97