-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-trace-base)!: Add parentSpanContext and remove parentSpanId #5450
Merged
pichlermarc
merged 17 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/(feat)-add-parent-context
Feb 18, 2025
Merged
feat(sdk-trace-base)!: Add parentSpanContext and remove parentSpanId #5450
pichlermarc
merged 17 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/(feat)-add-parent-context
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5450 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 309 309
Lines 8017 8021 +4
Branches 1706 1711 +5
=======================================
+ Hits 7614 7618 +4
Misses 403 403
|
pichlermarc
reviewed
Feb 13, 2025
pichlermarc
approved these changes
Feb 13, 2025
@JacksonWeber it seems that one of the commits modified file permissions (possibly something wrong with your git settings?) |
This reverts commit a17f85f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR adds the parentSpanContext to the Span and ReadableSpan in order to adhere to the OTel spec. And removes the
parentSpanId
as it is now redundant.Targets main OTel branch and will be accompanies another PR against the 1.x branch: #5422.
Fixes #5345
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests have been updated to include checks for the new
parentSpanContext
values and remove those checks for the formerparentSpanId
value.Checklist: