-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add parentSpanContext to Span and ReadableSpan #5422
base: v1.x
Are you sure you want to change the base?
feat: Add parentSpanContext to Span and ReadableSpan #5422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x #5422 +/- ##
=======================================
Coverage ? 94.66%
=======================================
Files ? 322
Lines ? 8061
Branches ? 1633
=======================================
Hits ? 7631
Misses ? 430
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop the parentSpanId
, but otherwise looks good 🙂
Thanks for the review! I'll update the description of the PR, but I discussed with Daniel in the JS SIG - the idea behind this PR is to target the 1.x branch with the non-breaking change of adding the |
I did not check which branch this is targeting.
@JacksonWeber my bad, did not see that this was targeting @dyladan does that mean that we're going to release a new |
@pichlermarc Looks like there might be a perms issue with the W3C integration tests running against v1.x branch. |
Which problem is this PR solving?
This PR adds the
parentSpanContext
to the Span and ReadableSpan in order to adhere to the OTel spec.Targets 1.x OTel, and will be accompanied by a follow-up PR against
main
with the breaking change of removingparentSpanId
.Fixes #5345
Type of change
How Has This Been Tested?
Existing tests have been updated to include checks for the new
parentSpanContext
values.Checklist: