Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: retrospectively add prometheus counter suffix change #2950

Merged
merged 4 commits into from
May 6, 2022
Merged

docs: retrospectively add prometheus counter suffix change #2950

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e17163f
docs: retrospectively add prometheus counter suffix change
legendecas May 4, 2022
fbed25b
Merge branch 'main' into upgrade-guideline
dyladan May 4, 2022
cdee7ed
Merge branch 'main' into upgrade-guideline
vmarchaud May 6, 2022
5b106ad
Merge branch 'main' into upgrade-guideline
dyladan May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,8 @@ Collector exporter packages and types are renamed:

- `serviceName` configuration removed from Collector exporters. Use `service.name` Resource attribute instead.

- Prometheus exporter added suffix `_total` to counter metrics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why blank line above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following the style convention arond the line.


### 0.18.x to 0.19.0

- API is now a peer dependency. This means that users will need to include `@opentelemetry/api` as a dependency of their project in order to use the SDK. NPM version 7+ (Node 15+) should do this automatically.
Expand Down