docs: retrospectively add prometheus counter suffix change #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 183 183
Lines 5909 5909
Branches 1254 1254
=======================================
Hits 5496 5496
Misses 413 413 |
dyladan
approved these changes
May 4, 2022
| @@ -365,6 +365,8 @@ Collector exporter packages and types are renamed: | |||
|
|
|||
| - `serviceName` configuration removed from Collector exporters. Use `service.name` Resource attribute instead. | |||
|
|
|||
| - Prometheus exporter added suffix `_total` to counter metrics. | |||
There was a problem hiding this comment.
I'm following the style convention arond the line.
vmarchaud
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2530
Short description of the changes
Add missing upgrade guideline entry for #2122.
Type of change
Checklist: