Use resource service.name as zipkin service name

[dyladan]

open-telemetry/opentelemetry-specification#472

Right now we get the service name from the config. While we can probably keep this as a manual override of sorts, we should infer the service name where we can.

[rezakrimi]

Hey, I'm willing to work on this. As far as I understand, we can detect the resource type and generate a Resource object. But I haven't seen any of the SERVICE_RESOURCE attributes (which includes service.name) being set in the code.

So is it right to detect the resource and set the zipkin service name to something like
this._serviceName = config.serviceName || resource.service.name?

[dyladan]

The resource comes attached to the first span. I would do something like this:

class ZipkinExporter
  public serviceName?: string;
  constructor(options) {
    // user can configure a service name
    if (typeof options.serviceName === "string")
      this.serviceName = options.serviceName;
    }
    // ...
  }

  public export(spans) {
    // if user has not configured service name, it comes from the first exported resource
    if (this.serviceName == null) {
      this.serviceName = spans[0].resource.labels["service.name"] ?? "Unnamed Service";
    }
    // ...
  }
}

[rezakrimi]

Thanks for the help. I'll be working on it.

[rezakrimi]

Is it okay to change the serviceName property of ZipkinExporter to be public?
I'm trying to write some tests cases to check its value.

[dyladan]

In tests you can access private variables like this

exporter["_privateProperty"]

[rezakrimi]

@dyladan I'm doing my internship at Google and I have linked my google account to my github account. But I'm still getting error for not signing CLA in my PR.

[dyladan]

Maybe @mayurkale22 can help here (he is a google employee)

[mayurkale22]

@dyladan I'm doing my internship at Google and I have linked my google account to my github account. But I'm still getting error for not signing CLA in my PR.

Post a comment ("I signed it") to the PR to recheck the signed CLA.

[rezakrimi]

@dyladan I'm doing my internship at Google and I have linked my google account to my github account. But I'm still getting error for not signing CLA in my PR.

Post a comment ("I signed it") to the PR to recheck the signed CLA.

seems like it didn't work.

[mayurkale22]

seems like it didn't work.

Not sure what went wrong, did you sign up as an individual (https://identity.linuxfoundation.org/?destination=node/285/individual-signup)?

[dyladan]

Do the interns sign up as individuals? I would assume they sign up as employees. @rezakrimi your manager should probably know.