Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Add otel resource label and service.name handling #8

Merged
merged 23 commits into from
Dec 4, 2020

Conversation

ericmustin
Copy link
Contributor

This PR Adds the Resource labels as span tags, and also uses the more canonical resource service.name to set the span's service when it exists.

This work brings us closer to the spec of how OTE service naming should work, and it's a pattern that's been addressed in other vendor/backend specific exporters

Work following this will be to ensure our documentation is appropriate for onboarding as well

@ericmustin
Copy link
Contributor Author

blocked by CI failures, checking in with opentelemetry-ruby

@ericmustin ericmustin merged commit 56b6503 into master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant