-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Introduce a new global level api.diag for internal Diagnostic Logging (Part 1) #1877
Comments
Please assign to me as I can't assign it myself |
Quick question: does the exact name has been discussed in the SIG today (i couldn't attend sadly), i feel like shortening to |
It was originally discussed 2 Sig's back, and part of the reason for the shortened name is to better support code minification, which is also the reason for introducing in the first place see #1754 for part of the discussion |
Okay cool i didn't miss anything then. I understand the code minification issue that of course impact everyone using otel, however i want to be sure that we all agree on "sacrificing" readability (at least in my opinion) for this goal. |
… diagnostic logging (Part 1) open-telemetry#1877
… diagnostic logging (Part 1) open-telemetry#1877
… diagnostic logging (Part 1) open-telemetry#1877
… diagnostic logging (Part 1) open-telemetry#1877
Quick question, is this logger intended to be usable by instrumentations and exporters or truly "internal"? I maintain the Google Cloud OTel exporters (in a different repo) where the code base also has plenty |
Yes, this is designed to be used for all "internal" diagnostic logging of the Api, Sdk's, instrumentations, exporters and all contributed components. So read "internal" as the OpenTelemetry and supporting components vs the "application" that uses OpenTelemetry as the diagnostic logs are local to the executing environment. |
This is included in v0.17 |
Introduction of new api.diag global logger as discussed during SIG meetings and linked to #1754
Basic outline
api.diag
with methods likeapi.diag.warn
,api.diag.debug
, etc.Part 1
Part 2
Will include breaking changes
The text was updated successfully, but these errors were encountered: