-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Introduce a new global level api.diag for internal Diagnostic Logging (Part 2) #1878
Comments
Please assign to me as I can't assign it myself This Part 2, will also wait until Part 1 #1877 is complete, released and the contrib repo updated |
@MSNev @obecny and I had a quick call about the diag logger. documenting decisions here for future reference:
Error, warn, info, debug, verbose, none/all
No. For now, components will call the global logger. This removes the OptionalDiagLogger and the getDiagLoggerFromConfig helpers. The logging global error handler will go to api.diag.error
We are going to leave this for a future enhancement. Existing getters for the logger will be changed to point to the api.diag logger. Other classes which don’t have existing getters will be changed to use api.diag directly at the point of use.
|
This is included in v0.17 |
Introduction of new api.diag global logger as discussed during SIG meetings and linked to #1754 and Part 1 #1877
Basic outline
api.diag
with methods likeapi.diag.warn
,api.diag.debug
, etc.Part 2
Will include breaking changes
The text was updated successfully, but these errors were encountered: