Options to ignore parent SampledFlag in ProbabilitySampler

[legendecas]

Is your feature request related to a problem? Please describe.

Spec https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#probability said that ProbabilitySampler can ignore the parent SampledFlag by a configuration

[dyladan]

It seems to me that this should be superseded by the ParentOrElse sampler? I'll create a spec issue to see what they think.

[legendecas]

If the ProbabilitySampler does not respect parent then it can be superseded by the ParentOrElse sampler composited with probability sampler. I think this is neat since they all do their own jobs.

[dyladan]

I created open-telemetry/opentelemetry-specification#704

We'll see what the specs approvers think.

[dyladan]

I think this is superceded by #1455 and #1487

Can this issue be closed or are you still working on this?

[legendecas]

@dyladan I think this one can be closed as #1279 has already landed. Closing.

[legendecas]

Sorry, I misunderstood the ping. This one is not done yet.

[dyladan]

@legendecas What I am saying is that this issue and #1455 (assigned to @shivkanya9146) appear to be duplicates, are they not?

[legendecas]

@dyladan I think so. So this issue can be closed as it been superseded by #1455 in terms of spec changes.