-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options to ignore parent SampledFlag in ProbabilitySampler #1284
Comments
It seems to me that this should be superseded by the |
If the ProbabilitySampler does not respect parent then it can be superseded by the ParentOrElse sampler composited with probability sampler. I think this is neat since they all do their own jobs. |
I created open-telemetry/opentelemetry-specification#704 We'll see what the specs approvers think. |
Sorry, I misunderstood the ping. This one is not done yet. |
@legendecas What I am saying is that this issue and #1455 (assigned to @shivkanya9146) appear to be duplicates, are they not? |
Is your feature request related to a problem? Please describe.
Spec https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#probability said that ProbabilitySampler can ignore the parent SampledFlag by a configuration
The text was updated successfully, but these errors were encountered: