Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ParentOrElse to ParentBased and generalize to support all cases #1455

Closed
dyladan opened this issue Aug 21, 2020 · 3 comments · Fixed by #1577
Closed

Rename ParentOrElse to ParentBased and generalize to support all cases #1455

dyladan opened this issue Aug 21, 2020 · 3 comments · Fixed by #1577
Labels
up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Aug 21, 2020

open-telemetry/opentelemetry-specification#610
@shivkanya9146
Copy link
Contributor

I would like to work on this, please assign to me

@dyladan dyladan mentioned this issue Sep 2, 2020
Closed
@dyladan
Copy link
Member Author

dyladan commented Sep 2, 2020

@shivkanya9146 do you have an update on this?

@dyladan
Copy link
Member Author

dyladan commented Sep 2, 2020

@legendecas is working on the parent sampled flag in the probability sampler and this issue is related.

@obecny obecny added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 30, 2020
@dyladan dyladan mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement parent based sampler dynatrace-oss-contrib/opentelemetry-js
3 participants
@obecny @dyladan @shivkanya9146