Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated release workflows #366

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Conversation

willarmiros
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds 2 GitHub workflows: 1 that automatically creates a release PR, and another that publishes all packages to NPM and cuts a GH release when that PR is merged. Most details are in Improve Release Automation #345, the only still unresolved matter is whether or not to create a draft release so you can judge for yourself after seeing the video.
  • You can see my runs of identical workflows on a test repo meant to simulate this repo here, and an example of an auto-generated release PR here. I'll also be posting a video of the whole process.

Flarna and others added 3 commits February 25, 2021 21:44
Update typescript and gts to new major versions.

Additionally update eslint and plugins to latest versions and fix some other minor issues like repository field in package.json.
@willarmiros willarmiros requested a review from a team February 26, 2021 05:55
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #366 (a5ff1bb) into main (92656a3) will not change coverage.
The diff coverage is n/a.

❗ Current head a5ff1bb differs from pull request most recent head d9d57ba. Consider uploading reports for the commit d9d57ba to get more accurate results

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          11       11           
  Lines         431      431           
  Branches       48       48           
=======================================
  Hits          407      407           
  Misses         24       24           

@willarmiros
Copy link
Contributor Author

willarmiros commented Feb 26, 2021

Darn, well I'm no good at video editing so it's too big to embed here on GitHub, but you can download the recording of the flow here: https://demo-video-otel-js-9y182zqovhunxlwv.s3-us-west-2.amazonaws.com/Screen+Recording+2021-02-25+at+8.45.39+PM.mov

Also, I'll be out next week. Unfortunate timing, but I'll likely be unresponsive til around 3/7.

@willarmiros
Copy link
Contributor Author

@dyladan can you all take a look when you get a chance? I'm back from my vacation and will be able to address any comments.

@willarmiros
Copy link
Contributor Author

@dyladan any chance for a review?

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, though i have a question about permission: who can launch the release workflow from github ? People with write access or do it need admin permission on the repo ?

RELEASING.md Outdated Show resolved Hide resolved
@willarmiros
Copy link
Contributor Author

overall LGTM, though i have a question about permission: who can launch the release workflow from github ? People with write access or do it need admin permission on the repo ?

@vmarchaud Anyone with write access can run it, but the manually-runnable workflow only creates the release PR. The PR still needs to be approved before merging, which actually triggers the publishing. So someone with write access could spam PRs (and hopefully get their write access revoked) but not actually release anything to the wild.

@dyladan
Copy link
Member

dyladan commented Mar 24, 2021

Apologize for late review. I was on vacation all last week

@dyladan
Copy link
Member

dyladan commented Mar 24, 2021

@obecny since this is fairly important I think we should have approval from all maintainers before merging

@obecny obecny merged commit f106054 into open-telemetry:main Mar 24, 2021
@obecny obecny added the enhancement New feature or request label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Release Automation
5 participants