Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript to 4.x and gts to 3.x #336

Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 5, 2021

Update typescript and gts to new major versions.

Additionally update eslint and plugins to latest versions and fix
some other minor issues like repository field in package.json.

Update typescript and gts to new major versions.

Additionally update eslint and plugins to latest versions and fix
some other minor issues like repository field in package.json.
@Flarna Flarna requested a review from a team February 5, 2021 18:51
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #336 (f8dfdaf) into main (b13740d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         135      135           
  Lines        7192     7194    +2     
  Branches      672      672           
=======================================
+ Hits         6834     6836    +2     
  Misses        358      358           
Impacted Files Coverage Δ
...opentelemetry-instrumentation-graphql/src/utils.ts 95.26% <100.00%> (+0.05%) ⬆️
node/opentelemetry-plugin-dns/src/utils.ts 97.95% <0.00%> (ø)
node/opentelemetry-plugin-mongodb/src/mongodb.ts 95.78% <0.00%> (ø)
node/opentelemetry-plugin-mysql/test/mysql.test.ts 98.28% <0.00%> (ø)
...etry-hapi-instrumentation/test/hapi-plugin.test.ts 100.00% <0.00%> (ø)

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for improving the tooling on both these repos.

@Flarna Flarna merged commit 17d9445 into open-telemetry:main Feb 9, 2021
@Flarna Flarna deleted the typescript-4_gts-3 branch February 9, 2021 16:57
willarmiros pushed a commit to willarmiros/opentelemetry-js-contrib that referenced this pull request Feb 26, 2021
Update typescript and gts to new major versions.

Additionally update eslint and plugins to latest versions and fix some other minor issues like repository field in package.json.
@obecny obecny added the enhancement New feature or request label Mar 5, 2021
obecny pushed a commit that referenced this pull request Mar 24, 2021
* chore: update typescript to 4.x and gts to 3.x (#336)

Update typescript and gts to new major versions.

Additionally update eslint and plugins to latest versions and fix some other minor issues like repository field in package.json.

* ci: added auto-publish release workflows and updated docs

* use express instr for example

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Co-authored-by: Valentin Marchaud <thisismac47@gmail.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants