chore: move opentelemetry-propagator-jaeger to core #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 11 11
Lines 431 431
Branches 48 48
=======================================
Hits 407 407
Misses 24 24 |
|
@jtmalinowski looks fine, however tests are failing :/ |
jtmalinowski
force-pushed
the
chore/adopt-jaeger-propagator
branch
2 times, most recently
from
ec8f828
to
18a6819
Compare
dyladan
changed the title
dyladan
approved these changes
Mar 10, 2021
vmarchaud
approved these changes
Mar 10, 2021
johnbley
approved these changes
Mar 25, 2021
|
@jtmalinowski can you please resolve conflicts ?, core PR has been merged, thx |
Move opentelemetry-propagator-jaeger from contrib to core (open-telemetry#1931). This is to enable turning on the jaeger propagator using ENV variables. Default Node Tracer Provider needs to depend on Jaeger propagator.
jtmalinowski
force-pushed
the
chore/adopt-jaeger-propagator
branch
from
d231375
to
348ecb9
Compare
|
@obecny done, but now tests are failing; seems unrelated to me, but if there's something I can do to help, let me know |
|
Tests fail because of an issue with transitive dependencies, and they are failing similarly on other PRs. |
obecny
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move opentelemetry-propagator-jaeger from contrib to core (open-telemetry/opentelemetry-js#1931).
This is to enable turning on the jaeger propagator using ENV variables.
Default Node Tracer Provider needs to depend on Jaeger propagator.
Which problem is this PR solving?
Short description of the changes