Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instrumentation-dns #302

Merged
merged 19 commits into from
Feb 9, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jan 13, 2021

port plugin-dns to instrumenation API because the plugin API will be removed from OTel.

fixes: #253

port plugin-dns to instrumenation API because the plugin API will be removed from OTel.
@Flarna Flarna requested a review from a team January 13, 2021 17:05
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #302 (77c5087) into main (118c5b1) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   95.29%   95.02%   -0.27%     
==========================================
  Files         124      135      +11     
  Lines        6690     7192     +502     
  Branches      639      672      +33     
==========================================
+ Hits         6375     6834     +459     
- Misses        315      358      +43     
Impacted Files Coverage Δ
...ry-instrumentation-dns/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
node/opentelemetry-instrumentation-dns/src/dns.ts 77.02% <0.00%> (ø)
...metry-instrumentation-dns/test/utils/assertSpan.ts 100.00% <0.00%> (ø)
...on-dns/test/integrations/dnspromise-lookup.test.ts 91.15% <0.00%> (ø)
...ode/opentelemetry-instrumentation-dns/src/utils.ts 97.95% <0.00%> (ø)
...ode/opentelemetry-instrumentation-dns/.eslintrc.js 0.00% <0.00%> (ø)
...instrumentation-dns/test/functionals/utils.test.ts 98.73% <0.00%> (ø)
...mentation-dns/test/integrations/dns-lookup.test.ts 92.37% <0.00%> (ø)
...ntelemetry-instrumentation-dns/test/utils/utils.ts 33.33% <0.00%> (ø)
...e/opentelemetry-instrumentation-dns/src/version.ts 100.00% <0.00%> (ø)
... and 1 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud linked an issue Jan 18, 2021 that may be closed by this pull request
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from master to main January 27, 2021 22:21
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Flarna Flarna added the enhancement New feature or request label Feb 3, 2021
@Flarna Flarna merged commit 9de77b1 into open-telemetry:main Feb 9, 2021
@Flarna Flarna deleted the instrumentation-dns branch February 9, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert dns plugin to instrumentation
4 participants