Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dns plugin to instrumentation #253

Closed
obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #302
Closed

Convert dns plugin to instrumentation #253

obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #302
Assignees
@Flarna
Labels
enhancement New feature or request

Comments

@obecny
Copy link
Member

obecny commented Nov 5, 2020 •
edited
Loading

  • Change folder name from opentelemetry-plugin-* to opentelemetry-instrumentation-*
  • Change package name from @opentelemetry/plugin-* to @opentelemetry/instrumentation-*
  • Change implementation to use InstrumentationBase
@obecny obecny added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 5, 2020
@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 18, 2021
@vmarchaud vmarchaud linked a pull request Jan 18, 2021 that will close this issue
feat: add instrumentation-dns #302
Merged
@Flarna Flarna mentioned this issue Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flarna Flarna

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add instrumentation-dns dynatrace-oss-contrib/opentelemetry-js-contrib
3 participants
@obecny @vmarchaud @Flarna