Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-express): Finish spans after execution #2603

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

onurtemizkan
Copy link
Contributor

Which problem is this PR solving?

Resolves: #2442

  • TBD

Short description of the changes

  • TBD

@onurtemizkan onurtemizkan force-pushed the express-middleware-span-termination branch 2 times, most recently from db5cf13 to 0d93cf6 Compare December 13, 2024 16:24
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (21e1331) to head (c60e4f7).

Files with missing lines Patch % Lines
...try-instrumentation-express/src/instrumentation.ts 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   90.78%   90.74%   -0.05%     
==========================================
  Files         169      169              
  Lines        8055     8057       +2     
  Branches     1643     1642       -1     
==========================================
- Hits         7313     7311       -2     
- Misses        742      746       +4     
Files with missing lines Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 95.80% <60.00%> (-2.78%) ⬇️

@onurtemizkan onurtemizkan force-pushed the express-middleware-span-termination branch from 939044d to 2fa7f9c Compare January 2, 2025 15:51
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:propagation-utils pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-instana pkg:sampler-aws-xray pkg:test-utils pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

express instrumentation - span end prematurely for non-middleware instrumentations