@opentelemetry/instrumentation-express handler does not account for async work

[aabmass]

What version of OpenTelemetry are you using?

├── @opentelemetry/api@1.8.0
└─┬ @opentelemetry/auto-instrumentations-node@0.43.0
  ├── @opentelemetry/api@1.8.0 deduped
  └── @opentelemetry/instrumentation-express@0.36.1

What version of Node are you using?

v18.19.1

What did you do?

Run the included express sample https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/express

What did you expect to see?

Async work should be accounted for in the handler duration.

What did you see instead?

The handler span has very short duration, only accounting for synchronous work. This is already a known caveat documented here but I couldn't find a tracking bug.

This screenshot demonstrates the problems

Additional context

A common pattern for express is to use an async function as the handler, as demonstrated in the sample

opentelemetry-js-contrib/examples/express/src/server.ts

Line 36 in 9df30ea

app.get('/run_test', async (req, res) => {

For handlers that return a promise, it should be possible to chain a span.end() call to the promise. However this also seems related to #2022

[raphael-theriault-swi]

This was previously addressed in #1657 but it was decided to open a separate PR for it, which I then forgot to do. Will be taking this one since I already have the code for it.

[aabmass]

@raphael-theriault-swi any update here?

[raphael-theriault-swi]

#2603 looks like a fix, sorry I had completely forgotten about this