Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update references to logging exporter #6692

Merged

Conversation

codeboten
Copy link
Contributor

This exporter has been replaced by the debug exporter and will be removed soon

Related to open-telemetry/opentelemetry-collector#11037

This exporter has been replaced by the debug exporter and will be removed soon

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team September 6, 2024 21:34
@codeboten codeboten changed the title docs: update references to logging exporter tests: update references to logging exporter Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (b0643fe) to head (5cc4276).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6692   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6390     6390           
=========================================
  Files           711      711           
  Lines         19333    19333           
  Branches       1891     1891           
=========================================
  Hits          17418    17418           
  Misses         1335     1335           
  Partials        580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This also appears to all be test code, so nothing externally facing or breaking.

Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else needed here or can it be merged?

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit 7990392 into open-telemetry:main Sep 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants