-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/logging] Remove logging exporter #11037
[exporter/logging] Remove logging exporter #11037
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11037 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 424 422 -2
Lines 20270 20202 -68
=======================================
- Hits 18535 18473 -62
+ Misses 1359 1354 -5
+ Partials 376 375 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of references on examples in language library repositories still that mention the logging exporter. This search has a lot of false positives, but it's a good start I think: https://github.com/search?q=org%3Aopen-telemetry+%22logging%3A%22+-repo%3Aopen-telemetry%2Fopentelemetry-collector+language%3AYAML+OR+language%3AMarkdown&type=code&p=1
We also have ~18% of survey respondents from the Collector survey raw data using the logging exporter so I think we need to do this very carefully.
At a minimum I feel like we need a migration page, and a very clear error message that tells you to use the debug exporter and links you to the migration page. Additionally, it would be great to have something like #7631 before we do this (not sure if it should be a hard requirement tho).
I am blocking this until we at least have no references to the logging exporter within examples in the OpenTelemetry org
#### Description Add warning to logging exporter on startup to remind users to switch to the debug exporter. #### Link to tracking issue Related to #11037 #### Testing ![image](https://github.com/user-attachments/assets/7d9cd908-6fdf-45c4-82f0-56cce35dbcee)
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
c541232
to
eb4045a
Compare
@mx-psi it has been another 4 weeks with an even louder warning and @codeboten has updated a majority of the loggingexporter references in language repos. I feel we should move forward with this removal. |
649f59e
to
42001aa
Compare
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened PRs to most of the remaining references to the logging
exporter found in the query that were not in archived repositories.
I don't know that it's worth waiting for all of them to be merged before moving this forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should block this PR (we can do this in a separate one) but I feel like we should give a clearer error message when trying to use the logging
exporter for a while.
For example, we can do the following: if a configuration file references a logging
exporter and the logging
exporter is not available, but the debug
exporter is, then add a hint to the error message suggesting the usage of the debug
exporter.
Based on the survey usage data, I expect this change to be quite disruptive for users and for us to get quite a few Slack messages and Github issues about this, so I would like to help users as much as possible
@mx-psi added an additional warning: receivers:
otlp:
protocols:
grpc:
exporters:
logging:
level: debug
service:
pipelines:
traces:
receivers:
- otlp
exporters:
- logging
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is ready to merge once we remove the exporter from the opentelemetry-collector-releases manifests
Releases PR: open-telemetry/opentelemetry-collector-releases#682 |
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
* 8.4: fixing some implicit nullable params * fix withspan handler nullable + example (#1377) - class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span * fix: update references to logging exporter (#1383) This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * fix: Update collector tag in example to latest (#1384) Follow-up from #1383. Debug exporter isn't available until v0.86.0, so this new configuration throws an error when trying to run the collector. `Error: cannot unmarshal the configuration: unknown exporters type "debug" for "debug"` Instead of setting to v0.86.0, I noticed the other docker files omitted the tag (so latest is pulled). I just updated this to match. * Remove `MeterInterface::isEnabled()` and fix meter config re-enabling (#1387) * Update SPI dependency to v1. (#1388) * Fix README badges. (#1389) * add phpDocumentor instructions to Makefile (#1385) * add phpDocumentor instructions to Makefile Signed-off-by: svrnm <neumanns@cisco.com> * update DEVELOPMENT.md Signed-off-by: svrnm <neumanns@cisco.com> --------- Signed-off-by: svrnm <neumanns@cisco.com> * Update README.md (#1344) * Fix `IncompatibleReturnValueException` in `MessageFactoryTest` (#1392) PSR7 `RequestInterface::getUri()` must return `UriInterface`, not `string`; explicit typehint was added in `2.0`. * more implicit nulls --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com> Co-authored-by: Tobias Bachert <git@b-privat.de> Co-authored-by: Chris Lightfoot-Wild <github-clw@wild.me.uk> Co-authored-by: Severin Neumann <neumanns@cisco.com> Co-authored-by: Oleg <142805497+devactivity-team@users.noreply.github.com>
* 8.4: fixing some implicit nullable params * fix withspan handler nullable + example (#1377) - class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span * fix: update references to logging exporter (#1383) This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * fix: Update collector tag in example to latest (#1384) Follow-up from #1383. Debug exporter isn't available until v0.86.0, so this new configuration throws an error when trying to run the collector. `Error: cannot unmarshal the configuration: unknown exporters type "debug" for "debug"` Instead of setting to v0.86.0, I noticed the other docker files omitted the tag (so latest is pulled). I just updated this to match. * Remove `MeterInterface::isEnabled()` and fix meter config re-enabling (#1387) * Update SPI dependency to v1. (#1388) * Fix README badges. (#1389) * add phpDocumentor instructions to Makefile (#1385) * add phpDocumentor instructions to Makefile Signed-off-by: svrnm <neumanns@cisco.com> * update DEVELOPMENT.md Signed-off-by: svrnm <neumanns@cisco.com> --------- Signed-off-by: svrnm <neumanns@cisco.com> * Update README.md (#1344) * Fix `IncompatibleReturnValueException` in `MessageFactoryTest` (#1392) PSR7 `RequestInterface::getUri()` must return `UriInterface`, not `string`; explicit typehint was added in `2.0`. * more implicit nulls --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com> Co-authored-by: Tobias Bachert <git@b-privat.de> Co-authored-by: Chris Lightfoot-Wild <github-clw@wild.me.uk> Co-authored-by: Severin Neumann <neumanns@cisco.com> Co-authored-by: Oleg <142805497+devactivity-team@users.noreply.github.com>
I pinned issue #11337 which we can use as the central place for any people that need help with the migration. We can keep it pinned and open for a couple weeks and close it after a while. I think this has enough approvals to merge so I am merging, thanks everyone for the hard work, let's hope this goes smoothly! |
#### Description It is September, which means we get to remove this deprecated component. - The helm chart was updated to exclude the logging exporter already: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/UPGRADING.md#0840-to-0850. - The Operator references have been updated: open-telemetry/opentelemetry-operator#3259. - Opentelemetry.io site final references to update: open-telemetry/opentelemetry.io#5143 <!-- Issue number if applicable --> #### Link to tracking issue Related to open-telemetry#7769
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
#### Description It is September, which means we get to remove this deprecated component. - The helm chart was updated to exclude the logging exporter already: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/UPGRADING.md#0840-to-0850. - The Operator references have been updated: open-telemetry/opentelemetry-operator#3259. - Opentelemetry.io site final references to update: open-telemetry/opentelemetry.io#5143 <!-- Issue number if applicable --> #### Link to tracking issue Related to open-telemetry#7769
Description
It is September, which means we get to remove this deprecated component.
Link to tracking issue
Related to #7769