Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move class that should've been internal to internal package #9725

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Move class that should've been internal to internal package #9725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...metry/instrumentation/api/instrumenter/http/HttpClientPeerServiceAttributesExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import io.opentelemetry.context.Context;
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
import io.opentelemetry.instrumentation.api.instrumenter.net.PeerServiceResolver;
import io.opentelemetry.instrumentation.api.instrumenter.url.UrlParser;
import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
import io.opentelemetry.semconv.SemanticAttributes;
import java.util.function.Supplier;
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceResolverImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import static java.util.Comparator.nullsFirst;

import com.google.auto.value.AutoValue;
import io.opentelemetry.instrumentation.api.instrumenter.url.UrlParser;
import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
import java.util.Comparator;
import java.util.HashMap;
import java.util.Map;
Expand Down
8 changes: 6 additions & 2 deletions ...ation/api/instrumenter/url/UrlParser.java → .../instrumenter/net/internal/UrlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.instrumentation.api.instrumenter.url;
package io.opentelemetry.instrumentation.api.instrumenter.net.internal;

import java.util.function.Predicate;
import javax.annotation.Nullable;

public class UrlParser {
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
public final class UrlParser {

@Nullable
public static String getHost(String url) {
Expand Down
1 change: 1 addition & 0 deletions ...nv/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/url/UrlParserTest.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not changing the package of the test class here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an oversight, can you send PR? thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9730

Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import static org.assertj.core.api.Assertions.assertThat;

import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
import org.junit.jupiter.api.Test;

class UrlParserTest {
Expand Down
Loading