Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move class that should've been internal to internal package #9725

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Move class that should've been internal to internal package #9725

merged 1 commit into from
Oct 20, 2023

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team October 20, 2023 06:38
@mateuszrzeszutek mateuszrzeszutek enabled auto-merge (squash) October 20, 2023 06:59
@mateuszrzeszutek mateuszrzeszutek merged commit 0ec55db into open-telemetry:main Oct 20, 2023
47 checks passed
mmorel-35
mmorel-35 reviewed Oct 20, 2023
View reviewed changes
...mconv/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/url/UrlParserTest.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not changing the package of the test class here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an oversight, can you send PR? thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9730

@mateuszrzeszutek mateuszrzeszutek deleted the move-internal-class branch October 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@mmorel-35 mmorel-35 mmorel-35 left review comments

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateuszrzeszutek @trask @laurit @mmorel-35