Don't override the OpenTelemetry bean in the OTel starter reactive tests #11256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
|
Perhaps rename the PR title to something like "Don't override the OpenTelemetry bean in the OTel starter reactive tests"? |
jeanbisutti
reviewed
Apr 29, 2024
...ke-testing/src/main/java/io/opentelemetry/spring/smoketest/SpringSmokeOtelConfiguration.java
Outdated
Show resolved
Hide resolved
zeitlinger
changed the title
zeitlinger
force-pushed
the
spring-testing-project
branch
from
20ac1e6
to
7c85331
Compare
zeitlinger
force-pushed
the
spring-testing-project
branch
from
3122fde
to
7c85331
Compare
zeitlinger
force-pushed
the
spring-testing-project
branch
from
aa24c0b
to
6aabe32
Compare
jeanbisutti
approved these changes
Apr 30, 2024
laurit
reviewed
Apr 30, 2024
Comment on lines
+79
to
+82
| @BeforeEach | ||
| void initOpenTelemetry() { | ||
| testing = new SpringSmokeTestRunner(openTelemetry); | ||
| } |
There was a problem hiding this comment.
as far as I can tell this doesn't really initialize open telemetry
There was a problem hiding this comment.
good point - I'll rename it in a later PR
laurit
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.