Add automatic MongoDB instrumentation to the OTel starter #11211

zeitlinger · 2024-04-23T15:04:09Z

zeitlinger · 2024-04-24T06:30:16Z

@jeanbisutti this test only fails in spring native mode with the following error:

Caused by: java.lang.ClassNotFoundException: org.springframework.data.mongodb.core.aggregation.AggregationOperation

Can you help?

jeanbisutti · 2024-04-25T16:45:38Z

@jeanbisutti this test only fails in spring native mode with the following error:

Caused by: java.lang.ClassNotFoundException: org.springframework.data.mongodb.core.aggregation.AggregationOperation

Can you help?

@zeitlinger It seems related to the Spring code, not the OTel Starter code (to check).

In this case, the following code in the RuntimeHints class solves the issue:

    hints
        .reflection()
        .registerType(
            TypeReference.of("org.springframework.data.mongodb.core.aggregation.AggregationOperation"),
            hint -> {
              hint.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS, MemberCategory.INVOKE_DECLARED_METHODS);
            });

jeanbisutti · 2024-04-26T10:44:28Z

@zeitlinger I confirm that the GraalVM native issue is related to the Spring code, not the OpenTelemetry code. I have pushed a fix on your branch.

...t-3/src/test/java/io/opentelemetry/smoketest/GraalVmNativeMongodbSpringStarterSmokeTest.java

...sts-otel-starter/spring-boot-3/src/main/java/io/opentelemetry/spring/smoketest/Customer.java

...g-boot-3/src/test/java/io/opentelemetry/smoketest/AbstractMongodbSpringStarterSmokeTest.java

...spring-boot-3/src/test/java/io/opentelemetry/smoketest/JvmMongodbSpringStarterSmokeTest.java

...t-3/src/test/java/io/opentelemetry/smoketest/GraalVmNativeMongodbSpringStarterSmokeTest.java

jeanbisutti

Maybe rename the PR to something more specific, like "Add automatic MongoDB instrumentation to the OTel starter"?

...-3/src/main/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTestController.java

...g-boot-3/src/test/java/io/opentelemetry/smoketest/AbstractMongodbSpringStarterSmokeTest.java

.../spring/autoconfigure/instrumentation/mongo/MongoClientInstrumentationAutoConfiguration.java

…lemetry/smoketest/JvmMongodbSpringStarterSmokeTest.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>

laurit · 2024-05-16T12:27:40Z

.../spring/autoconfigure/instrumentation/mongo/MongoClientInstrumentationAutoConfiguration.java

+            MongoTelemetry.builder(openTelemetry)
+                .setStatementSanitizationEnabled(
+                    config.getBoolean(
+                        "otel.instrumentation.mongo.statement-sanitizer.enabled", true))


agent uses the value of common sanitizer property as the default

fixed in #11350

laurit · 2024-05-16T12:32:50Z

...mmon/src/main/java/io/opentelemetry/spring/smoketest/AbstractOtelSpringStarterSmokeTest.java

+    @EventListener(ApplicationReadyEvent.class)
+    public void loadData() {
+      jdbcTemplate
+          .getObject()
+          .execute("create table test_table (id bigint not null, primary key (id))");
+    }


how is this related to mongo?

moved from another class so that the mongo test is not affected

zeitlinger self-assigned this Apr 23, 2024

zeitlinger requested a review from a team April 23, 2024 15:04

github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Apr 23, 2024

zeitlinger mentioned this pull request Apr 23, 2024

spring doc updates for 2.4.0 #11212

Closed

4 tasks

zeitlinger force-pushed the spring-mongo branch from 5fe8db7 to 93f6c20 Compare April 29, 2024 06:24

zeitlinger marked this pull request as draft April 29, 2024 06:52

zeitlinger force-pushed the spring-mongo branch from 93f6c20 to ea0c629 Compare April 29, 2024 15:43

jeanbisutti reviewed Apr 29, 2024

View reviewed changes

...t-3/src/test/java/io/opentelemetry/smoketest/GraalVmNativeMongodbSpringStarterSmokeTest.java Outdated Show resolved Hide resolved

zeitlinger force-pushed the spring-mongo branch 2 times, most recently from 1cf8c56 to 5070000 Compare April 30, 2024 13:13

zeitlinger marked this pull request as ready for review April 30, 2024 13:59

jeanbisutti reviewed Apr 30, 2024

View reviewed changes

zeitlinger changed the title ~~support mongo client~~ Add automatic MongoDB instrumentation to the OTel starter May 2, 2024

zeitlinger force-pushed the spring-mongo branch from 5790fd9 to 83f0d0a Compare May 2, 2024 14:57

jeanbisutti reviewed May 3, 2024

View reviewed changes

...-3/src/main/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTestController.java Outdated Show resolved Hide resolved

...g-boot-3/src/test/java/io/opentelemetry/smoketest/AbstractMongodbSpringStarterSmokeTest.java Outdated Show resolved Hide resolved

zeitlinger commented May 3, 2024

View reviewed changes

.../spring/autoconfigure/instrumentation/mongo/MongoClientInstrumentationAutoConfiguration.java Outdated Show resolved Hide resolved

zeitlinger marked this pull request as draft May 3, 2024 09:06

zeitlinger force-pushed the spring-mongo branch from 83f0d0a to a7efacc Compare May 14, 2024 10:45

zeitlinger added this to the v2.4.0 milestone May 14, 2024

zeitlinger and others added 7 commits May 15, 2024 20:44

support mongo client

e6ae2f2

support mongo client

566a9ba

Fix GraalVM native issue

a28a49d

spotless

bf31b6c

mongo smoke test

243025e

mongo smoke test with external docker image

657062f

support local testing for mongo test

44684c5

zeitlinger and others added 9 commits May 15, 2024 20:44

support local testing for mongo test

ed8c988

support local testing for mongo test

b7bb541

fix test

89c2f25

Update smoke-tests-otel-starter/spring-boot-3/src/test/java/io/opente…

a10b036

…lemetry/smoketest/JvmMongodbSpringStarterSmokeTest.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>

review

74d4ca5

rebase

d6b08ca

mongodb test

6892251

mongodb test

83c03a6

fix dependencies

7966050

zeitlinger force-pushed the spring-mongo branch from 5893dac to 7966050 Compare May 15, 2024 18:44

zeitlinger marked this pull request as ready for review May 16, 2024 04:52

create table only in jdbc test

df3f576

jeanbisutti approved these changes May 16, 2024

View reviewed changes

zeitlinger mentioned this pull request May 16, 2024

make statement sanitizer configurable for spring boot #11350

Merged

laurit reviewed May 16, 2024

View reviewed changes

laurit approved these changes May 16, 2024

View reviewed changes

laurit merged commit 6b66434 into open-telemetry:main May 16, 2024
53 checks passed

zeitlinger deleted the spring-mongo branch May 16, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add automatic MongoDB instrumentation to the OTel starter #11211

Add automatic MongoDB instrumentation to the OTel starter #11211

zeitlinger commented Apr 23, 2024 •

edited

Loading

zeitlinger commented Apr 24, 2024

jeanbisutti commented Apr 25, 2024

jeanbisutti commented Apr 26, 2024

jeanbisutti left a comment

laurit May 16, 2024

zeitlinger May 16, 2024

laurit May 16, 2024 •

edited

Loading

zeitlinger May 16, 2024

Add automatic MongoDB instrumentation to the OTel starter #11211

Add automatic MongoDB instrumentation to the OTel starter #11211

Conversation

zeitlinger commented Apr 23, 2024 • edited Loading

zeitlinger commented Apr 24, 2024

jeanbisutti commented Apr 25, 2024

jeanbisutti commented Apr 26, 2024

jeanbisutti left a comment

Choose a reason for hiding this comment

laurit May 16, 2024

Choose a reason for hiding this comment

zeitlinger May 16, 2024

Choose a reason for hiding this comment

laurit May 16, 2024 • edited Loading

Choose a reason for hiding this comment

zeitlinger May 16, 2024

Choose a reason for hiding this comment

zeitlinger commented Apr 23, 2024 •

edited

Loading

laurit May 16, 2024 •

edited

Loading