Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collector): allow deployment of ingress for standaloneCollector #92

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

secustor
Copy link
Member

Allows to deploy an ingress object for the collector service

Fixes #76

@secustor secustor requested review from a team October 21, 2021 22:16
@secustor
Copy link
Member Author

secustor commented Nov 8, 2021

Can somebody restart the pipeline. It seems like the scheduling has failed

@secustor
Copy link
Member Author

@dmitryax

@mahparaashley
Copy link
Contributor

Really interested in this feature.

@dmitryax
Copy link
Member

dmitryax commented Feb 3, 2022

Sorry for the delay. I need to look deeply into this use case. Will review later this week

@secustor
Copy link
Member Author

secustor commented Feb 3, 2022

This is one of the use cases https://docs.google.com/presentation/d/1jPDH8Csv-Qle7Z-P7rFJgjOsBpgKeehPhjFPqTRET1Y/mobilepresent#slide=id.gf87b11edd5_0_182

A static website is instrumented with OpenTelemetry and sends telemetry to an OTLP endpoint.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit ffd0d36 into open-telemetry:main Feb 7, 2022
@secustor secustor deleted the add_ingress branch February 7, 2022 07:37
matej-g pushed a commit to matej-g/opentelemetry-helm-charts that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional ingress for otel collector
3 participants