Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ingress for otel collector #76

Closed
pragmaticivan opened this issue Sep 14, 2021 · 3 comments · Fixed by #92
Closed

Add optional ingress for otel collector #76

pragmaticivan opened this issue Sep 14, 2021 · 3 comments · Fixed by #92

Comments

@pragmaticivan
Copy link

It might be useful for exposing the collector for SPA apps (react) and perhaps adding another way of redirecting requests to a oauth proxy.

@dmitryax
Copy link
Member

Hi @secustor @pragmaticivan , can you please provide more evidence why the ingress should be part of the collector helm chart?

The general idea is to keep this helm chart thin and provide only necessary resources to support OpenTelemetry collector in k8s environment.

I don't believe that ingress has to be part of this chart. I think it should be deployed with nginx-ingress helm chart separately.

@secustor
Copy link
Member

secustor commented Nov 12, 2021

I'm not sure, if we talk about the same.

What I'm referencing is a simple Ingress object like in my PR, which cannot be deployed using the nginx-ingress helm chart. Usually these are packaged with the corresponding applications. e.g. Loki from Grafana and Jaeger

Regarding the addition of an ingress controller to this helm chart. I'm of your opinion, this should not be included in this helm chart.

My use case is to ingest data from external applications which are instrumentalized with Opentelemetry.
To secure the endpoint an API gateway is used and most API gateway implementations, I'm aware of, utilize ingress objects as basis for their configurations.

@pragmaticivan
Copy link
Author

Same as above. This ticket was intended for the Ingress resource, not the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants