Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename environment variables for demo/featureflag-service #344

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Rename environment variables for demo/featureflag-service #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a509cb3
Rename environment variables for featureflag service to match what is…
joshleecreates Aug 27, 2022
76e6d36
Use default service port for featureflagservice grpc
joshleecreates Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/opentelemetry-demo/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
type: application
name: opentelemetry-demo
version: 0.2.1
version: 0.2.2
description: opentelemetry demo helm chart
home: https://opentelemetry.io/
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/opentelemetry-demo/templates/_pod.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Get Pod Env

{{- if eq .name "product-catalog-service" }}
- name: FEATURE_FLAG_GRPC_SERVICE_ADDR
value: {{ (printf "%s-featureflag-service:%0.f" $prefix .servicePort ) }}
value: {{ (printf "%s-featureflag-service:50031" $prefix ) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging this hard coded value as a temporary fix. Will address as part of #340

{{- end }}

# {{ $.depends }}
Expand Down
10 changes: 5 additions & 5 deletions charts/opentelemetry-demo/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ components:
# If a different url is desired, set DATABASE_URL here.
# - name: DATABASE_URL
# value:
- name: GRPC_PORT
- name: FEATURE_FLAG_GRPC_SERVICE_PORT
joshleecreates marked this conversation as resolved.
Show resolved Hide resolved
value: '50053'
- name: PORT
value: '50052'
- name: FEATURE_FLAG_SERVICE_PORT
value: '8081'
ports:
- name: grpc
value: 50052
- name: http
value: 50053
- name: http
value: 8081
podAnnotations: {}
# instrumentation.opentelemetry.io/inject-sdk: "true"

Expand Down