Rename environment variables for demo/featureflag-service #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expected in the service
|
|
|
@joshleecreates Can you fix the product catalog as well if it is broken? |
|
Also please bump the patch version in the chart.yaml |
joshleecreates
force-pushed
the
main
branch
2 times, most recently
from
dbb33bc
to
bd035be
Compare
|
@TylerHelmuth I'm not sure if using port 8080 was the right move here but it seemed reasonable to match this line: |
joshleecreates
force-pushed
the
main
branch
2 times, most recently
from
4fe44ac
to
2644f67
Compare
TylerHelmuth
approved these changes
Aug 29, 2022
Allex1
approved these changes
Aug 30, 2022
| @@ -91,7 +91,7 @@ Get Pod Env | |||
|
|
|||
| {{- if eq .name "product-catalog-service" }} | |||
| - name: FEATURE_FLAG_GRPC_SERVICE_ADDR | |||
| value: {{ (printf "%s-featureflag-service:%0.f" $prefix .servicePort ) }} | |||
| value: {{ (printf "%s-featureflag-service:50031" $prefix ) }} | |||
There was a problem hiding this comment.
Logging this hard coded value as a temporary fix. Will address as part of #340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with the featureflagservice pod not starting in #343
There is probably a better way to do this in the .tpl files, and the product-catalog-service appears to have the wrong port for the feature flag grpc.