-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename environment variables for demo/featureflag-service #344
Conversation
… expected in the service
|
@joshleecreates Can you fix the product catalog as well if it is broken? |
Also please bump the patch version in the chart.yaml |
dbb33bc
to
bd035be
Compare
@TylerHelmuth I'm not sure if using port 8080 was the right move here but it seemed reasonable to match this line:
|
4fe44ac
to
2644f67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this
@@ -91,7 +91,7 @@ Get Pod Env | |||
|
|||
{{- if eq .name "product-catalog-service" }} | |||
- name: FEATURE_FLAG_GRPC_SERVICE_ADDR | |||
value: {{ (printf "%s-featureflag-service:%0.f" $prefix .servicePort ) }} | |||
value: {{ (printf "%s-featureflag-service:50031" $prefix ) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging this hard coded value as a temporary fix. Will address as part of #340
This fixes the issue with the featureflagservice pod not starting in #343
There is probably a better way to do this in the .tpl files, and the product-catalog-service appears to have the wrong port for the feature flag grpc.