WIP: Metric uniqueness checking #566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
March 12, 2020 17:22
jmacd
requested review from
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
This is not really up for review, it's just to help with #560. I'm not quite pleased with the addition of an argument to the |
|
I will do this over after #560 merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfinished proof of concept for #514, intended to help with the review for #520
Changes:
metric.MeterImplimpl that keeps state about registered instruments and calls through to the real implementationmetric.Descriptorfield for the library nameNone of these details are intended for final review and could change, but this should demonstrate how #560 helps address #514.