Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure metric name and kind uniqueness #514

Closed
jmacd opened this issue Mar 4, 2020 · 1 comment · Fixed by #580
Closed

Ensure metric name and kind uniqueness #514

jmacd opened this issue Mar 4, 2020 · 1 comment · Fixed by #580
Assignees
@jmacd
Labels
area:metrics Part of OpenTelemetry Metrics
Milestone
Alpha v0.3 (Beta)

Comments

@jmacd
Copy link
Contributor

jmacd commented Mar 4, 2020

The specification states:

The Meter will return an error when a metric name is already registered with a different kind for the same name.

See the comment in open-telemetry/opentelemetry-specification#498 (comment)
@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Mar 4, 2020
@rghetia rghetia added this to the Alpha v0.3 (Beta) milestone Mar 5, 2020
@jmacd
Copy link
Contributor Author

jmacd commented Mar 7, 2020

The global SDK facility will need a way to report errors at the moment when a new SDK is set as the global instance. This suggests that we carry out #174 and expose an error handlers on the Meter (and Trace) SDKs. Then, when the global SDK encounters instrument constructor errors it will have something to do with them.

This was referenced Mar 7, 2020
Merged
Merged
This was referenced Mar 16, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
Alpha v0.3 (Beta)
Development

Successfully merging a pull request may close this issue.

Unique instrument checking jmacd/opentelemetry-go
2 participants
@jmacd @rghetia